Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add formatting dropdown to mapping dated for products #1296

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Apr 20, 2023

Description

Adds type to the datetime fields for the Commerce Products mapping screen.
It’s only throwing an error in v5 but should be added to v4 and v5 for consistency.

To take effect, you need to re-save your feed, so that the date fields get the formatting option (currently missing from the mapping screen for Commerce Products).

Related issues

#1287

@i-just i-just requested a review from angrybrad as a code owner April 20, 2023 09:57
@angrybrad angrybrad merged commit 33c405c into v4 Apr 27, 2023
@angrybrad angrybrad deleted the bugfix/1287-mapping-dates-for-products branch April 27, 2023 22:43
angrybrad added a commit that referenced this pull request Apr 27, 2023
@angrybrad angrybrad mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants